Add mesh conformance tests for httproute path host and status redirect #3777
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
LiorLieberman
force-pushed
the
httproute-mesh-tests-2
branch
from
2309607 to
515fa33
Compare
|
/cc @kflynn |
| // This option indicates mesh support for HTTPRoute scheme redirect (extended conformance) | ||
| SupportMeshHTTPRouteSchemeRedirect FeatureName = "MeshHTTPRouteSchemeRedirect" | ||
| // This option indicates mesh support for HTTPRoute port redirect (extended conformance) | ||
| SupportMeshHTTPRouteRedirectPort FeatureName = "MeshHTTPRouteRedirectPort" | ||
| // This option indicates mesh support for HTTPRoute path redirect (extended conformance) | ||
| SupportMeshHTTPRouteRedirectPath FeatureName = "MeshHTTPRouteRedirectPath" |
There was a problem hiding this comment.
Can any of these features be considered core support for mesh?
There was a problem hiding this comment.
🤔 What does L7 functionality being core imply for Istio Ambient?
There was a problem hiding this comment.
Ambient mode will pass the conformance tests by deploying a waypoint for all the workloads (and already does this). It doesn't implement gateway API outside of waypoints (including TcpRoute)
There was a problem hiding this comment.
So Istio is fine with core functionality requiring waypoints?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@LiorLieberman, thanks for sticking with this! /lgtm |
k8s-ci-robot
added
the
lgtm
What type of PR is this?
/area conformance-test
Add mesh tests for port and scheme redirect
This is a follow up to #3729
What this PR does / why we need it:
Add mesh tests coverage
Which issue(s) this PR fixes:
Related #3581
Does this PR introduce a user-facing change?: